Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API should reject events with both recurrence.count and recurrence_end #196

Open
osteele opened this issue Apr 29, 2018 · 0 comments
Open
Labels
api Issues that affect the ABE API clients

Comments

@osteele
Copy link
Contributor

osteele commented Apr 29, 2018

These are not valid iCalendar events. Currently the server ignores recurrence.count when recurrence_end is present. Better would be not to allow such data to enter the store.

This will require an update to sample_events.json.

This doesn't strictly require, but should probably be done in conjunction with, cleaning the dev and production databases. A query of production db.getCollection('event').find({recurrence_end: {$exists: true}, "recurrence.count": {$exists: true}}, {title:1, start:1, recurrence_end:1, recurrence:1}) shows six events in production that contain both fields, as of 2018-04-29. Visual inspection shows that the count and end date of each of these events are consistent, so it doesn't matter which is removed. db.getCollection('event').update({recurrence_end: {$exists: true}, "recurrence.count": {$exists: true}}, {$unset: {"recurrence.count: false}}) (untested) ought to remove the recurrence end from these events.

@osteele osteele added the api Issues that affect the ABE API clients label Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that affect the ABE API clients
Projects
None yet
Development

No branches or pull requests

1 participant