Skip to content
This repository has been archived by the owner on Sep 19, 2019. It is now read-only.

Input text boxes chop off periods, 0s at end #1

Open
kylecombes opened this issue May 3, 2018 · 0 comments
Open

Input text boxes chop off periods, 0s at end #1

kylecombes opened this issue May 3, 2018 · 0 comments

Comments

@kylecombes
Copy link
Contributor

Because the data flows like so:
a) input parsed as float, sent to via WebSockets to ROS
b) parsed float sent over ROS
c) parsed float read by ROS subscriber, forwarded to dashboard via WS
d) received data used to set text box content

it means that any non-numeric characters must be added between existing numeric characters to avoid being stripped during the string-to-float conversion.

Proposed solution

  • Don't use ROS as the source of truth, rather use the component state.
  • To continue giving some indicator, compare the value stored in the component state to the value stored in the Redux state (set via ROS & WS) and give some sort of visual indicator as to when they don't agree (perhaps a red outline on the box).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant