Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code needs some cleaning and optimizations #9

Open
4 of 6 tasks
olange opened this issue Apr 14, 2022 · 0 comments
Open
4 of 6 tasks

Code needs some cleaning and optimizations #9

olange opened this issue Apr 14, 2022 · 0 comments
Assignees
Labels
‹focus› Our current focus technical story Technical feature, refactoring and chores

Comments

@olange
Copy link
Owner

olange commented Apr 14, 2022

There are obsolete code fragments inherited from the ObservableHQ notebook (see #1), which shall be removed (for instance, decide for a bounding box algorithm).

Actions

  • Does the bounding sphere algorithm really work better than the bounding box of the areas? Check whether we really need all the code of the bsphereGeom() getter
  • The infobox at the bottom of the map should go, it was just there to show state and help development DONE 06.09.2022 commit 64fbd03
    • then remove injected id property from this._projectionDef (h3-worldmap.js:willUpdate()), which was introduced by PR Removes property “id” from projections list #21 — as it served only the display of the infobox;
    • and restore usage of 100% of available height for the worldmap — currently arbitrarily fixed at 66vh because of the space used by the infobox (src/views/host.js:hostStyles)
  • Optimizations: review the geometry builder functions, that return the D3 projections (_buildPathFn(), _pathFn(), src/core/geometries/**), and determine how they could cache their computations, as long as their sources did not change; probably be they should be defined at willUpdate() time — instead of being recalculated anytime they get invoked, as it is now the case
  • Formatting: run npm run format, eventually tweak the ES Linter/Prettier settings (I saw some pedantic end-of-HTML-tag alone on a line, which are not desirable IMO), and version the results NOTE 29.04 OL moved this to Review and tweak ‹ES Lint› and ‹Prettier› settings #22

See also

@olange olange added the technical story Technical feature, refactoring and chores label Apr 14, 2022
@olange olange changed the title Code needs some cleaning Code needs some cleaning and optimizations Apr 28, 2022
olange added a commit to rudifa/h3-worldmap that referenced this issue Apr 29, 2022
Needs a separate commit, linked to olange#9.
@olange olange added the ‹focus› Our current focus label Apr 29, 2022
@olange olange added this to the Initial release milestone Apr 29, 2022
olange added a commit that referenced this issue Sep 6, 2022
Its a while we wanted to remove it – now done.
@olange olange self-assigned this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‹focus› Our current focus technical story Technical feature, refactoring and chores
Projects
None yet
Development

No branches or pull requests

1 participant