You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are obsolete code fragments inherited from the ObservableHQ notebook (see #1), which shall be removed (for instance, decide for a bounding box algorithm).
Actions
Does the bounding sphere algorithm really work better than the bounding box of the areas? Check whether we really need all the code of the bsphereGeom() getter
The infobox at the bottom of the map should go, it was just there to show state and help development DONE 06.09.2022 commit 64fbd03
then remove injected id property from this._projectionDef (h3-worldmap.js:willUpdate()), which was introduced by PR Removes property “id” from projections list #21 — as it served only the display of the infobox;
and restore usage of 100% of available height for the worldmap — currently arbitrarily fixed at 66vh because of the space used by the infobox (src/views/host.js:hostStyles)
Optimizations: review the geometry builder functions, that return the D3 projections (_buildPathFn(), _pathFn(), src/core/geometries/**), and determine how they could cache their computations, as long as their sources did not change; probably be they should be defined at willUpdate() time — instead of being recalculated anytime they get invoked, as it is now the case
Formatting: run npm run format, eventually tweak the ES Linter/Prettier settings (I saw some pedantic end-of-HTML-tag alone on a line, which are not desirable IMO), and version the results NOTE 29.04 OL moved this to Review and tweak ‹ES Lint› and ‹Prettier› settings #22
There are obsolete code fragments inherited from the ObservableHQ notebook (see #1), which shall be removed (for instance, decide for a bounding box algorithm).
Actions
bsphereGeom()
getterDONE
06.09.2022 commit 64fbd03id
property fromthis._projectionDef
(h3-worldmap.js:willUpdate()
), which was introduced by PR Removes property “id” from projections list #21 — as it served only the display of the infobox;66vh
because of the space used by the infobox (src/views/host.js:hostStyles
)_buildPathFn()
,_pathFn()
,src/core/geometries/**
), and determine how they could cache their computations, as long as their sources did not change; probably be they should be defined atwillUpdate()
time — instead of being recalculated anytime they get invoked, as it is now the casenpm run format
, eventually tweak the ES Linter/Prettier settings (I saw some pedantic end-of-HTML-tag alone on a line, which are not desirable IMO), and version the resultsNOTE
29.04 OL moved this to Review and tweak ‹ES Lint› and ‹Prettier› settings #22See also
The text was updated successfully, but these errors were encountered: