Thank you for taking your time to improve Onload. We would appreciate if you follow the contributing guidelines to make review of changes easier.
- Fork Onload repository on https://github.com/Xilinx/onload
- Make local short-lived branch off of public master.
- Develop on branch locally. Please describe the changes you have made in the commit messages.
- Try to follow the coding conventions used in the files you edit.
- Push branch to your fork of Onload repository.
- Create a new Pull Request. Please describe what testing you have done.
- Address review comments.
- You need to get sign-off of two other developers before the Pull Request can be merged.
In general try to follow the style that is used in the file. Most of the files use:
- Line length limit of 79 characters.
- Two space indentation.
- C style comments (no C++ style comments).
- Opening braces are not put on their own line.
- No space between keyword and bracket.
For instance,
/* This is a comment */
if( ! conditional_expr ) {
statement1;
statement2;
}
This file: (c) Copyright 2020 Xilinx, Inc.