Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete unit test test_verify_expiration ? #75

Open
bew opened this issue Dec 18, 2024 · 0 comments
Open

Incomplete unit test test_verify_expiration ? #75

bew opened this issue Dec 18, 2024 · 0 comments

Comments

@bew
Copy link

bew commented Dec 18, 2024

Hello,

While reading the source code of this library I noticed something strange:

# verify token is expired
claims = {'ver': 1,
'jti': 'test_jti_str',
'iss': issuer,
'iat': iss_time,
'exp': iss_time-300,
'uid': 'test_uid',
'scp': ['openid'],
'sub': '[email protected]'}
with pytest.raises(JWTValidationException):
jwt_verifier.verify_expiration('test_token')

The variable claims is never used again so is basically useless. Mistake? bad copy/paste?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant