From 9f936e4b4a8a288e6d7774af7519af9d6377b0b1 Mon Sep 17 00:00:00 2001 From: Sergey Nikitin Date: Fri, 1 Dec 2023 20:51:19 +0300 Subject: [PATCH] issue #190: add missed noreturn attribute Mark __ci_sys_fail() as noreturn to stop objtool generating "__ci_sys_fail() is missing a __noreturn annotation" warning. Signed-off-by: Sergey Nikitin --- src/include/ci/tools/log.h | 2 +- src/lib/citools/sys_fail.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/ci/tools/log.h b/src/include/ci/tools/log.h index fdda39f56..4bb365de2 100644 --- a/src/include/ci/tools/log.h +++ b/src/include/ci/tools/log.h @@ -209,7 +209,7 @@ __ci_fail(const char* fmt, ...) CI_PRINTF_LIKE(1,2) CI_HF; #define ci_fail(x) \ do{ ci_log("FAIL at %s:%d", __FILE__, __LINE__); __ci_fail x; }while(0) -extern void __ci_sys_fail(const char* fn, int rc, +extern CI_NORETURN __ci_sys_fail(const char* fn, int rc, const char* file, int line) CI_HF; #define ci_sys_fail(fn, rc) __ci_sys_fail(fn, rc, __FILE__, __LINE__) diff --git a/src/lib/citools/sys_fail.c b/src/lib/citools/sys_fail.c index 487f4b744..d553d72ba 100644 --- a/src/lib/citools/sys_fail.c +++ b/src/lib/citools/sys_fail.c @@ -16,7 +16,7 @@ #include "citools_internal.h" -void __ci_sys_fail(const char* fn, int rc, const char* file, int line) +CI_NORETURN __ci_sys_fail(const char* fn, int rc, const char* file, int line) { ci_log("*** UNEXPECTED ERROR ***"); ci_log(" what: %s", fn);