Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cross-platform db issue #431

Closed
wants to merge 5 commits into from
Closed

fix cross-platform db issue #431

wants to merge 5 commits into from

Conversation

kavigupta
Copy link
Contributor

@kavigupta kavigupta commented Jul 15, 2020 •
edited
Loading

Resolves #374 by just deleting the file if there's an error

itsvs
itsvs approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@itsvs itsvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

itsnshaw
itsnshaw approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@itsnshaw itsnshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itsvs
Copy link
Member

itsvs commented Jan 23, 2022

closing due to lack of activity

@itsvs itsvs closed this Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsnshaw itsnshaw itsnshaw approved these changes

@itsvs itsvs itsvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross-platform incompatibility
3 participants
@kavigupta @itsvs @itsnshaw