Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve report panel large cells handling #698

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

roll
Copy link
Collaborator

@roll roll commented Dec 18, 2024


One of the options to make it easily consumable. BTW can you please share the file from the issue @romicolman?

@roll roll requested review from guergana and romicolman December 18, 2024 11:11
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sorry for the late response on this ticket. The example file is in the ticket, here.

I have just checked the implementation. I'm adding a video to show how the tooltip looks like on the errors report panel. We have a lot of blank space on the sidebar when content is large. I don't know if we can improve that. If that's not possible or if there is not other solution, please, let's implement.

Grabacion.de.pantalla.2024-12-23.a.la.s.10.12.16.a.m.mov

@guergana regarding your comment. We are checking tooltip on the errors report panel, but your screenshot if from the datagrid. Can you calarify? Thanks

Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: dad8a66
Status: ✅  Deploy successful!
Preview URL: https://59e8577a.opendataeditor.pages.dev
Branch Preview URL: https://652-fix-report-large-cells.opendataeditor.pages.dev

View logs

@roll
Copy link
Collaborator Author

roll commented Dec 23, 2024

@romicolman
I have fixed it, can you please check?

@guergana
Copy link
Collaborator

Hi! Sorry for the late response on this ticket. The example file is in the ticket, here.

I have just checked the implementation. I'm adding a video to show how the tooltip looks like on the errors report panel. We have a lot of blank space on the sidebar when content is large. I don't know if we can improve that. If that's not possible or if there is not other solution, please, let's implement.
Grabacion.de.pantalla.2024-12-23.a.la.s.10.12.16.a.m.mov

@guergana regarding your comment. We are checking tooltip on the errors report panel, but your screenshot if from the datagrid. Can you calarify? Thanks

Ah, my bad, @romicolman yes, my comment was about the datagrid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltip when content in cell is large
3 participants