Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH URI #26

Open
RonWang opened this issue Jun 3, 2019 · 1 comment
Open

SSH URI #26

RonWang opened this issue Jun 3, 2019 · 1 comment

Comments

@RonWang
Copy link

RonWang commented Jun 3, 2019

Hi! I've been using this great library for a while and doesn't have problem at all. Until I try to use it to validate a github ssh url, like "git@github:xxx/repo.git". Is this SSH uri also a valid url that we should support in this library?

*Reference for the ssh url https://tools.ietf.org/id/draft-salowey-secsh-uri-00.html.

@adrienv1520
Copy link

Hi @RonWang,

I was facing the same issues with valid-url but also validator so I decided to build a module as reliable as possible strictly based on RFC-3986: https://github.com/adrienv1520/node-uri

The main features of this project are:

  • parse any URI (URNs, URLs, URIs with IDNs support, etc.);
  • get the safe Punycode ASCII or Unicode serialization of a domain;
  • check an URI, HTTP/HTTPS/Sitemap URL, IP, domain is valid with clear checking errors;
  • encode/decode an URI, HTTP/HTTPS/Sitemap URL.

I hope it could help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants