Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM does not detect the MIT licence #22

Open
jaller94 opened this issue Nov 13, 2018 · 3 comments
Open

NPM does not detect the MIT licence #22

jaller94 opened this issue Nov 13, 2018 · 3 comments

Comments

@jaller94
Copy link

NPM is not picking up on this project being MIT licensed. The licence detection is used by a couple of compliance analyzers, so it would be helpful to change the entry from none to MIT.
I am not sure what the issue is.

https://www.npmjs.com/package/valid-url

@smellems
Copy link

smellems commented Sep 27, 2019

I think it's because the license was added after the last release.

Please make a new release with the updated license. It's causing build issues when validating licenses.

Thanks!

@lencioni
Copy link

Hi @ogt 👋 would it be possible to get a new version of this package published with the new license? Thank you!

@adrienv1520
Copy link

This project, so as validatorhas a lot of issues and is not a reliable way to valid an URL.

I was facing a lot of issues so I decided to build a module as reliable as possible strictly based on RFC-3986: https://github.com/adrienv1520/node-uri

The main features of this project are:

  • parse any URI (URNs, URLs, URIs with IDNs support, etc.);
  • get the safe Punycode ASCII or Unicode serialization of a domain;
  • check an URI, HTTP/HTTPS/Sitemap URL, IP, domain is valid with clear checking errors;
  • encode/decode an URI, HTTP/HTTPS/Sitemap URL.

I hope it could help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants