Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDowns Incompatibility with stack-in cards #120

Open
sdrapha opened this issue Mar 7, 2022 · 11 comments
Open

DropDowns Incompatibility with stack-in cards #120

sdrapha opened this issue Mar 7, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@sdrapha
Copy link
Contributor

sdrapha commented Mar 7, 2022

Starting on HA version 2022.3
The dropdowns don't show correclty if the mini-media-playerlink card is used inside a custom:stack-in-cardlink or a custom:vertical-stack-in-card link

image

I'll cross post this issue on the other involved custom cards repos, as I don't know what is the root cause for the issue.

Cross posted issues:
kalkih/mini-media-player#631
custom-cards/stack-in-card#40

@DanielSCBO
Copy link

@therealhalifax
Copy link

therealhalifax commented Mar 21, 2022

same for me. I think it came with the HA 2022.03 update. something changed in the lovelace system.

I replaced custom:vertical-stack-in-card with vertical-stack and the issue is gone. so the root cause seems to be in the custom vertical-stack-in

@Piti8576
Copy link

Same Problem.
Home Assistant 2022.3.7
Bildschirmfoto 2022-03-24 um 12 17 09

@tm24fan8
Copy link

tm24fan8 commented May 9, 2022

Same problem as well, my dropdowns disappear behind the next card. They work fine in a normal vertical stack.

@ScottG489
Copy link

I think the problem may be that generally any kind of overflow gets hidden.

I've seen this problem as well with other things such as when adjusting input_number sliders. The indicator showing what number you've selected that pops up above the slider will get cut off slightly if it's at the top of the card.

@Kolia56
Copy link

Kolia56 commented Oct 29, 2022

Same with me. So I fallbacked to regular vertical card. Running 2022.10
I used this fix given in another post (need card_mod that I already had installed)

card_mod:
style: |
ha-card {
overflow: visible !important;
}

@ScottG489
Copy link

Would the fix for this then to have that styling built in to the card?

It looks like we even explicitly hide overflow:
https://github.com/ofekashery/vertical-stack-in-card/blob/master/vertical-stack-in-card.js#L41

Looks like it was done in this commit: d0cb3bf

Looking at the commit and issues it fixed (#70 and #81) it's still not clear to me why we needed to hide overflow though.

@ofekashery Since you made that change, care to weigh in? Would it be as simple as removing card.style.overflow = 'hidden'; or is that styling necessary to fix other issues?

@sdrapha
Copy link
Contributor Author

sdrapha commented Dec 16, 2022

I made a PR to fix this issue, half an year ago already, is there any concern blocking it from being merged @ofekashery? Apreciate your thoughts. I'm using my modified version since then, flawless, couldn't find any collaterel effect, it just works.

@jbtrystram
Copy link

@sdrapha thanks for finding the issue. I tried to manually edit the line in www/community/vertical-stack-in-card/vertical-stack-in-card.js but it does not work. Do I need to remove it from HACS and download your fork ?
(if so, a rebase would be awesome)

@sdrapha
Copy link
Contributor Author

sdrapha commented Jan 6, 2023

@jbtrystram , if you manually edit the .js file. you probably need to delete the .gz file.
Also, don't forget to clear your browsers cache.
It should work.

@jbtrystram
Copy link

@sdrapha thanks for your answer. It appears to work only for one of my cards, but not the others. Also if I delete everything in the JS file my dashboards stops working, but when entering the "edit" widget it is still displayed properly. So there is some cache messing with this.

@ofekashery ofekashery added the enhancement New feature or request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants