Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build file fixes #139

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Build file fixes #139

merged 3 commits into from
Dec 7, 2024

Conversation

Harry282
Copy link
Contributor

@Harry282 Harry282 commented Dec 6, 2024

This pull request fixes and improves the gradle build script.

  • Fix "No provider for Pack200", explanation below
  • Auto download JDK 8 if needed for simpler build process

Since the great refactor (commit 528bcad), the build file has been broken. Only machines that already have the minecraft dependencies cached could compile the mod (including the automated GitHub Actions). This fix allows new machines and forked projects to correctly compile the mod.

@odtheking odtheking merged commit 0fec1e7 into odtheking:main Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants