[FIX] estate & estate_account: Fixed all the comments on PR

Author: malm-odoo

estate/models/__init__.py

@@ -1 +1,5 @@
-from . import estate_property, estate_property_type, estate_property_tag, estate_property_offer, users
+from . import estate_property
+from . import estate_property_type
+from . import estate_property_tag
+from . import estate_property_offer
+from . import users

estate/models/estate_property.py

@@ -54,21 +54,20 @@ class EstateProperty(models.Model):
 
     @api.constrains('selling_price', 'expected_price')
     def _check_prices_difference(self):
-        for record in self:
-            if record.buyer_id and float_compare(record.selling_price, 0.9 * record.expected_price, 5) == -1:
+        for estate in self:
+            if estate.buyer_id and float_compare(estate.selling_price, 0.9 * estate.expected_price, 5) == -1:
                 raise UserError(_("Selling price cannot be lower than 90% of the expected price!"))
 
     @api.depends('garden_area', 'living_area')
     def _compute_total_area(self):
-        for record in self:
-            record.total_area = record.garden_area + record.living_area
+        for estate in self:
+            estate.total_area = estate.garden_area + estate.living_area
 
     @api.depends('offer_ids.price')
     def _compute_best_price(self):
-        for record in self:
-            prices = record.offer_ids.mapped('price')
-
-            record.best_price = max(prices) if len(prices) > 0 else 0
+        for estate in self:
+            prices = estate.offer_ids.mapped('price')
+            estate.best_price = max(prices, default=0)
 
     @api.onchange('garden')
     def _onchange_garden(self):
@@ -80,29 +79,29 @@ def _onchange_garden(self):
             self.garden_orientation = ''
 
     def action_cancel(self):
-        for record in self:
-            if record.state == 'cancelled':
+        for estate in self:
+            if estate.state == 'cancelled':
                 raise UserError(_("Property already cancelled!"))
-            elif record.state == 'sold':
+            elif estate.state == 'sold':
                 raise UserError(_("A sold property cannot be cancelled!"))
             else:
-                self.state = 'cancelled'
+                estate.state = 'cancelled'
 
         return True
 
     def action_sold(self):
-        for record in self:
-            if record.state == 'sold':
+        for estate in self:
+            if estate.state == 'sold':
                 raise UserError(_("Property already sold!"))
-            elif record.state == 'cancelled':
+            elif estate.state == 'cancelled':
                 raise UserError(_("A cancelled property cannot be sold!"))
             else:
-                self.state = 'sold'
+                estate.state = 'sold'
 
         return True
 
     @api.ondelete(at_uninstall=False)
     def prevent_deletion(self):
-        for record in self:
-            if record.state != 'new' and record.state != 'cancelled':
+        for estate in self:
+            if estate.state not in ['new', 'cancelled']:
                 raise UserError(_("You can only delete new or cancelled properties!"))

estate/models/estate_property_offer.py

@@ -22,8 +22,8 @@ class EstatePropertyOffer(models.Model):
     property_id = fields.Many2one('estate.property', string="Property", required=True)
     validity = fields.Integer(string="Validity", default=7)
     date_deadline = fields.Date(compute='_compute_date_deadline', inverse='_inverse_date_deadline', string="Date Deadline")
-    create_date = fields.Date(default=lambda self: fields.Datetime.now())
-    property_type_id = fields.Many2one(related="property_id.property_type_id")
+    create_date = fields.Date(default=lambda self: fields.Datetime.now(), string="Create Date")
+    property_type_id = fields.Many2one(related="property_id.property_type_id", string="Property Type ID")
 
     _sql_constraints = [
         ('check_offer_price', 'CHECK(price > 0)',
@@ -32,14 +32,13 @@ class EstatePropertyOffer(models.Model):
 
     @api.depends('validity', 'create_date')
     def _compute_date_deadline(self):
-        for record in self:
-            record.date_deadline = record.create_date + timedelta(days=record.validity)
+        for offer in self:
+            offer.date_deadline = offer.create_date + timedelta(days=offer.validity)
 
     def _inverse_date_deadline(self):
-        for record in self:
-            delta = record.date_deadline - record.create_date
-
-            record.validity = delta.days
+        for offer in self:
+            delta = offer.date_deadline - offer.create_date
+            offer.validity = delta.days
 
     def action_confirm(self):
         self.ensure_one()
@@ -62,13 +61,13 @@ def action_confirm(self):
         return True
 
     def action_refuse(self):
-        for record in self:
-            if record.status == 'refused':
+        for offer in self:
+            if offer.status == 'refused':
                 raise UserError(_("Offer already refused!"))
-            elif record.status == 'accepted':
+            elif offer.status == 'accepted':
                 raise UserError(_("Can't refuse an accepted offer!"))
             else:
-                record.status = 'refused'
+                offer.status = 'refused'
 
         return True
 

estate/models/estate_property_type.py

@@ -8,9 +8,9 @@ class EstatePropertyType(models.Model):
     _order = 'name'
 
     name = fields.Char(string="Name", required=True)
-    property_ids = fields.One2many('estate.property', 'property_type_id')
+    property_ids = fields.One2many('estate.property', 'property_type_id', string="Property Ids")
     sequence = fields.Integer(string='Sequence')
-    offer_ids = One2many('estate.property.offer', 'property_type_id')
+    offer_ids = One2many('estate.property.offer', 'property_type_id', string="Offer Ids")
     offer_count = fields.Integer(compute="_compute_offer_count", string="Offer Count")
 
     _sql_constraints = [
@@ -19,5 +19,5 @@ class EstatePropertyType(models.Model):
 
     @api.depends('offer_ids')
     def _compute_offer_count(self):
-        for record in self:
-            record.offer_count = len(record.offer_ids)
+        for type in self:
+            type.offer_count = len(type.offer_ids)

estate_account/models/estate_property.py

@@ -6,19 +6,18 @@ class InheritedEstateProperty(models.Model):
 
     def action_sold(self):
         invoices = []
-        for record in self:
-            journal = self.env['account.journal'].search([('type', '=', 'sale')])
-
+        journal = self.env['account.journal'].search([('type', '=', 'sale')], limit=1)
+        for estate in self:
             invoice = {
-                'partner_id': record.buyer_id.id,
+                'partner_id': estate.buyer_id.id,
                 'move_type': 'out_invoice',
                 'journal_id': journal.id,
                 'line_ids': [
                     Command.create(
                         {
-                            'name': record.name,
+                            'name': estate.name,
                             'quantity': 1,
-                            'price_unit': 0.06 * record.selling_price,
+                            'price_unit': 0.06 * estate.selling_price,
                         }
                     ),
                     Command.create(