[IMP] realestate: add kanban view and polish code

Author: adak-ahmed

estate_account/models/__init__.py

@@ -1,2 +1,2 @@
 from . import estate_account
-from . import realestate
+from . import realestate_property

estate_account/models/estate_account.py

@@ -3,4 +3,5 @@
 
 class EstateAccount(models.Model):
     _name = "estate.account"
+    _description = "EstateAccount"
     name = fields.Char(required=True)

estate_account/models/realestate.py renamed to estate_account/models/realestate_property.py

@@ -1,21 +1,21 @@
-from odoo import models, fields, Command
+from odoo import models, Command
 
 
 class Realestate(models.Model):
-    _name = "realestate"
-    _inherit = "realestate"
+    _name = "realestate_property"
+    _inherit = "realestate_property"
 
     def action_set_property_sold(self):
         self.env["account.move"].create(
             {
-                "partner_id": super().buyer_id.id,
+                "partner_id": self.buyer_id.id,
                 "move_type": "out_invoice",
                 "line_ids": [
                     Command.create(
                         {
                             "name": self.name,
                             "quantity": 1,
-                            "price_unit": super().selling_price,
+                            "price_unit": self.selling_price,
                         }
                     )
                 ],

estate_account/security/ir.model.access.csv

@@ -1,3 +1,3 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_estate_account,access.estate_acount,model_estate_account,,1,1,1,1
-access_realestate,access.realestate,model_realestate,,1,1,1,1
+access_realestate_property,access.realestate_property,model_realestate_property,,1,1,1,1

realestate/__manifest__.py

@@ -3,13 +3,10 @@
     "depends": ["base"],
     "data": [
         "security/ir.model.access.csv",
-        "views/estate_view.xml",
-        "views/owner_view.xml",
-        "views/tag_view.xml",
-        "views/seller_view.xml",
-        "views/buyer_view.xml",
-        "views/offer_view.xml",
-        "views/type_view.xml",
+        "views/realestate_property_view.xml",
+        "views/realestate_tag_view.xml",
+        "views/realestate_offer_view.xml",
+        "views/realestate_types_view.xml",
     ],
     "application": True,
     "installable": True,

realestate/models/__init__.py

@@ -1,7 +1,4 @@
-from . import realestate
-from . import owner
-from . import types
-from . import tags
-from . import seller
-from . import buyer
-from . import offer
+from . import realestate_property
+from . import realestate_types
+from . import realestate_tags
+from . import realestate_offer

realestate/models/buyer.py

@@ -4,29 +4,33 @@
 
 
 class Offer(models.Model):
-    _name = "offer"
+    _name = "realestate_offer"
     _order = "price desc"
+    _description = "Offer"
     price = fields.Float()
     status = fields.Selection([("accepted", "Accepted"), ("refused", "Refused")])
     buyer_id = fields.Many2one("res.partner")
-    property_id = fields.Many2one("realestate")
+    property_id = fields.Many2one("realestate_property")
     property_type_id = fields.Many2one(related="property_id.type_id")
     state = fields.Selection(related="property_id.state")
     validity = fields.Integer()
-    deadline = fields.Date(compute="_compute_deadline", inverse="_inverse_deadline")
+    deadline_date = fields.Date(
+        compute="_compute_deadline", inverse="_inverse_deadline"
+    )
     highest_offer = fields.Float(compute="_calc_highest_price")
 
     @api.depends("validity")
     def _compute_deadline(self):
         for record in self:
-            record.deadline = (
+            record.deadline_date = (
                 record.create_date or fields.Datetime.now()
             ).date() + timedelta(days=record.validity)
 
     def _inverse_deadline(self):
         for record in self:
             record.validity = (
-                record.deadline - (record.create_date or fields.Datetime.now()).date()
+                record.deadline_date
+                - (record.create_date or fields.Datetime.now()).date()
             ).days
 
     def set_offer_accepted(self):
@@ -53,7 +57,7 @@ def set_offer_refused(self):
     ]
 
     def create(self, vals):
-        res = super(Offer, self).create(vals)
+        res = super().create(vals)
 
         if res.price < res.property_id.best_price:
             raise UserError("Please set a higher price!")

realestate/models/owner.py

@@ -3,8 +3,8 @@
 
 
 class Realestate(models.Model):
-    _name = "realestate"
-    _description = "Estate"
+    _name = "realestate_property"
+    _description = "Properties"
     _order = "type_id"
     name = fields.Char(required=True)
     description = fields.Text()
@@ -38,26 +38,23 @@ class Realestate(models.Model):
         ],
         default="new",
     )
-    owner_id = fields.Many2one("buyer")
-    type_id = fields.Many2one("types", widget="handle")
-    tag_ids = fields.Many2many("tags", string="Tags")
-    seller_id = fields.Many2one("seller")
+    owner_id = fields.Many2one("res.partner")
+    type_id = fields.Many2one("realestate_types", widget="handle")
+    tag_ids = fields.Many2many("realestate_tags", string="Tags")
+    seller_id = fields.Many2one("res.partner")
     buyer_id = fields.Many2one("res.partner")
-    offer_ids = fields.One2many("offer", "property_id")
-    status = fields.Selection(related="offer_ids.status")
-    price = fields.Float(related="offer_ids.price")
-    validity = fields.Integer(related="offer_ids.validity")
-    deadline = fields.Date(related="offer_ids.deadline")
+    offer_ids = fields.One2many("realestate_offer", "property_id")
+
     total_area = fields.Integer(compute="_compute_total")
-    best_price = fields.Float(compute="_max_offer_price")
+    best_price = fields.Float(compute="_compute_max_offer_price")
 
     @api.depends("living_area", "garden_area")
     def _compute_total(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
     @api.depends("offer_ids")
-    def _max_offer_price(self):
+    def _compute_max_offer_price(self):
         for record in self:
             record.best_price = max(record.offer_ids.mapped("price"), default=0)
 
@@ -68,7 +65,7 @@ def _onchange_garden(self):
             self.garden_orientation = "north"
         else:
             self.garden_area = 0
-            self.garden_orientation = ""
+            self.garden_orientation = False
 
     def action_set_property_sold(self):
         for record in self:
@@ -82,34 +79,25 @@ def action_set_property_cancelled(self):
                 raise UserError("Sold properties cannot be Cancelled")
             record.state = "cancelled"
 
-    # def action_set_offer_accepted(self):
-    #     for record in self:
-    #         if record.status
-
     _sql_constraints = [
         (
             "check_expected_price",
-            "CHECK(expected_price> 0)",
+            "CHECK(expected_price > 0)",
             "Expected price must be positive.",
         ),
         (
             "check_selling_price",
-            "CHECK(selling_price> 0)",
+            "CHECK(selling_price > 0)",
             "Selling price must be positive.",
         ),
-        (
-            "check_offer_price",
-            "CHECK(price> 0)",
-            "Offer price must be positive.",
-        ),
     ]
 
     @api.constrains("selling_price")
     def _validate_selling_price(self):
         for record in self:
             if record.selling_price < 0.9 * record.expected_price:
                 raise ValidationError(
-                    "Selling price must be at least 90'%' of the expected price"
+                    "Selling price must be at least 90% of the expected price"
                 )
 
     @api.constrains("offer_ids")