[FIX] runbot: prevent crash with invalid exception #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williambraecky
force-pushed
the
17.0-fix-upgrade-exception-crash-wbr
branch
from
86c9f03
to
400448d
Compare
Xavier-Do
reviewed
Nov 18, 2024
runbot/models/upgrade.py
Outdated
| @@ -20,7 +20,7 @@ def _compute_message(self): | |||
| exception.message = message_layout.format(exception=exception, base_url=exception.get_base_url()) | |||
|
|
|||
| def _generate(self): | |||
| exceptions = self.search([]) | |||
| exceptions = self.search([('elements', '!=', False)]) | |||
There was a problem hiding this comment.
Je pense que ca aurait plus de sens de mettre une contrainte required sur le champ :)
There was a problem hiding this comment.
Faut delete les exceptions alors, sinon la contrainte pourra pas être appliquée :p
There was a problem hiding this comment.
Faut delete les exceptions alors, sinon la contrainte pourra pas être appliquée :p
Ha oui bien entendu. Maintenant le client js aura connaissance du required et empèchera de sauvegarder quand même je pense ;)
Williambraecky
force-pushed
the
17.0-fix-upgrade-exception-crash-wbr
branch
from
400448d
to
a72be05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.