Master pivot cache adrm #7427
Open
Master pivot cache adrm #7427
+269
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Contributor
Author
|
We can also probably remove the PivotPresencePlugin and the getter/helper getFirstPivotFunction - didn't try yet |
hokolomopo
force-pushed
the
master-pivot-cache-adrm
branch
from
f28927a to
6220c2b
Compare
hokolomopo
commented
Nov 7, 2025
Comment on lines
+57
to
+59
| evaluationListenerRegistry.replace("PivotUIPlugin", { | ||
| handleEvaluationMessage: this.handleEvaluationMessage.bind(this), | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
using a registry is maybe foireux, it will explode if we have multiple models (does it happen in practice ? maybe with dashboard/version history ?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist