Skip to content

[FIX] composer: change mode to editing when composer cursor selection changes #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[FIX] composer: change mode to editing when composer cursor selection changes #7400

wants to merge 1 commit into from

Conversation

@rmbh-odoo
Copy link
Contributor

@rmbh-odoo rmbh-odoo commented Nov 4, 2025 •
edited
Loading

Description:

Current behavior before PR:

  • When typing =sum( and pressing the Home key, selecting a range caused weird
    behavior in the composer.
  • The same issue occurred when using Ctrl+A to select the entire text.

Desired behavior after PR is merged:

  • Changing the cursor selection now correctly switches the mode to 'editing'.

Task: 5226615

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 4, 2025

Pull request status dashboard

rrahir
rrahir requested changes Nov 7, 2025
View reviewed changes
@rmbh-odoo
[FIX] composer: change mode to editing when composer cursor selection…
2c38d58 
… changes

Before this commit:
- When typing '=sum(' and pressing the Home key, selecting a range caused weird
  behavior in the composer.
- The same issue occurred when using Ctrl+A to select the entire text.

After this commit:
- Changing the cursor selection now correctly switches the mode to 'editing'.

Task: 5226615
@rmbh-odoo rmbh-odoo force-pushed the 17.0-fix-composer-range-selection-rmbh branch from 6971b3b to 2c38d58 Compare November 8, 2025 05:34
@rmbh-odoo rmbh-odoo changed the title [FIX] composer: make edition mode depend on cursor selection [FIX] composer: change mode to editing when composer cursor selection changes Nov 8, 2025
rrahir
rrahir reviewed Nov 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrahir rrahir rrahir requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmbh-odoo @robodoo @rrahir