Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] CoreViewPlugin: Remove access to dispatch #5216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] CoreViewPlugin: Remove access to dispatch #5216

wants to merge 1 commit into from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Nov 18, 2024

The CoreView plugins have a local state that is directly derived from the core data. As such, they should not have any impact on plugins other than themselves, especially not on core plugins.

This revision removes the dispatch fro the core view plugins altogether as they don't and should not dispatch anything.

Task: 4241403

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 18, 2024

Pull request status dashboard

rrahir added a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
f46e94d 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

Task: 4241141
This was referenced Nov 18, 2024
Closed
Closed
robodoo pushed a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
fd31d5f 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

closes #5071

Task: 4241141
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
fw-bot pushed a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
0067449 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

Task: 4241141
X-original-commit: fd31d5f
@fw-bot fw-bot mentioned this pull request Nov 18, 2024
Closed
14 tasks
rrahir added a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
8d9df64 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

Task: 4241141
X-original-commit: fd31d5f
robodoo pushed a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
b480f9f 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

closes #5217

Task: 4241141
X-original-commit: fd31d5f
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
fw-bot pushed a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
8a3d026 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

Task: 4241141
X-original-commit: b480f9f
@fw-bot fw-bot mentioned this pull request Nov 18, 2024
Closed
14 tasks
fw-bot pushed a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
1d6ce2f 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

Task: 4241141
X-original-commit: b480f9f
@fw-bot fw-bot mentioned this pull request Nov 18, 2024
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
5222d9a 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

closes #5222

Task: 4241141
X-original-commit: b480f9f
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
robodoo pushed a commit that referenced this pull request Nov 18, 2024
@rrahir
[FIX] Datavalidation: coreView plugin should not dispatch
64a4cbc 
See #5216 - CoreView plugins replay remote revisions and should not take
the risk to dispatch during the replay. The code that was assigning
arbitrary default values to the cells of a boolean datavalidation has
been moved to a UI feature plugin, hence avoiding the problem raised in
PR #5216.

closes #5221

Task: 4241141
X-original-commit: b480f9f
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@rrahir
[IMP] CoreViewPlugin: Remove access to dispatch
b93be84 
The CoreView plugins have a local state that is directly derived from the
core data. As such, they should not have any impact on plugins other than
themselves, especially not on core plugins.

This revision removes the dispatch fro the core view plugins altogether
as they don't and should not dispatch anything.

Task: 4241403
@rrahir rrahir force-pushed the master-remove-core-view-dispatch-rar branch from 9845f30 to b93be84 Compare November 18, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrahir @robodoo