From d56818c6865f47d930e7e274ccc152614bbd71e7 Mon Sep 17 00:00:00 2001
From: dhrp-odoo <dhrp@odoo.com>
Date: Tue, 12 Nov 2024 15:01:07 +0530
Subject: [PATCH] [FIX] data_bar_rule_editor: disable "No Color" button

This PR introduces two changes:

1. Fixes a traceback error in the Conditional Formatting Databar
editor by hiding the "Reset" button when not applicable.

2. Prevents errors by validating color input earlier to avoid empty
string parsing issues.

Task: 4102704
---
 .../side_panel/conditional_formatting/cf_editor/cf_editor.ts  | 4 ++++
 .../conditional_formatting/cf_editor/data_bar_rule_editor.xml | 1 +
 2 files changed, 5 insertions(+)

diff --git a/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts b/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts
index 7703f631bc..39629054c9 100644
--- a/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts
+++ b/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts
@@ -563,6 +563,10 @@ export class ConditionalFormattingEditor extends Component<Props, SpreadsheetChi
   }
 
   updateDataBarColor(color: Color) {
+    if (!isColorValid(color)) {
+      return;
+    }
+
     this.state.rules.dataBar.color = Number.parseInt(color.substr(1), 16);
   }
 
diff --git a/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml b/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml
index 95c63e3c9c..471761cfcf 100644
--- a/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml
+++ b/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml
@@ -5,6 +5,7 @@
       <RoundColorPicker
         currentColor="colorNumberString(rule.color)"
         onColorPicked.bind="updateDataBarColor"
+        disableNoColor="true"
       />
       <div class="o-section-subtitle">Range of values</div>
       <SelectionInput