Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] data_bar_rule_editor: disable "No Color" button #5191

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

dhrp-odoo
Copy link
Contributor

Description:

This PR introduces two changes:

  1. Fixes a traceback error in the Conditional Formatting Databar editor by hiding the "Reset" button when not applicable.

  2. Prevents errors by validating color input earlier to avoid empty string parsing issues.

Task: 4102704

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

This PR introduces two changes:

1. Fixes a traceback error in the Conditional Formatting Databar
editor by hiding the "Reset" button when not applicable.

2. Prevents errors by validating color input earlier to avoid empty
string parsing issues.

Task: 4102704
@robodoo
Copy link
Collaborator

robodoo commented Nov 12, 2024

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants