[FIX] PivotSidePanel: Allow unbounded range in the side panel

The code converting the selectionInput value into a valid dataset for
the pivot definition did not account for unbounded zones.

closes #4870

Task: 4126669
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>

Author: rrahir

src/components/side_panel/pivot/pivot_side_panel/pivot_spreadsheet_side_panel/pivot_spreadsheet_side_panel.ts

@@ -1,5 +1,4 @@
 import { Component, useState } from "@odoo/owl";
-import { splitReference, toZone } from "../../../../../helpers";
 import { SpreadsheetPivotRuntimeDefinition } from "../../../../../helpers/pivot/spreadsheet_pivot/runtime_definition_spreadsheet_pivot";
 import { SpreadsheetPivot } from "../../../../../helpers/pivot/spreadsheet_pivot/spreadsheet_pivot";
 import { Store, useLocalStore } from "../../../../../store_engine";
@@ -76,15 +75,15 @@ export class PivotSpreadsheetSidePanel extends Component<Props, SpreadsheetChild
 
   onSelectionConfirmed() {
     if (this.state.range) {
-      const { sheetName, xc } = splitReference(this.state.range);
-      const sheetId = sheetName
-        ? this.env.model.getters.getSheetIdByName(sheetName)
-        : this.env.model.getters.getActiveSheetId();
-      if (!sheetId) {
+      const range = this.env.model.getters.getRangeFromSheetXC(
+        this.env.model.getters.getActiveSheetId(),
+        this.state.range
+      );
+      if (range.invalidSheetName || range.invalidXc) {
         return;
       }
-      const zone = toZone(xc);
-      const dataSet = { sheetId, zone };
+
+      const dataSet = { sheetId: range.sheetId, zone: range.zone };
       this.store.update({ dataSet });
       // Immediately apply the update to recompute the pivot fields
       this.store.applyUpdate();

tests/pivots/pivot_side_panel.test.ts

@@ -1,6 +1,7 @@
-import { Model, SpreadsheetChildEnv } from "../../src";
+import { Model, SpreadsheetChildEnv, SpreadsheetPivotCoreDefinition } from "../../src";
+import { toZone } from "../../src/helpers";
 import { createSheet, deleteSheet } from "../test_helpers/commands_helpers";
-import { click } from "../test_helpers/dom_helper";
+import { click, setInputValueAndTrigger, simulateClick } from "../test_helpers/dom_helper";
 import { mountSpreadsheet, nextTick } from "../test_helpers/helpers";
 import { SELECTORS, addPivot, removePivot } from "../test_helpers/pivot_helpers";
 
@@ -45,4 +46,18 @@ describe("Pivot side panel", () => {
     await nextTick();
     expect(fixture.querySelector(".o-sidePanel")).not.toBeNull();
   });
+
+  test("Side panel supports unbounded zone in definition", async () => {
+    env.openSidePanel("PivotSidePanel", { pivotId: "1" });
+    await nextTick();
+    setInputValueAndTrigger(SELECTORS.ZONE_INPUT, "A:A");
+    await nextTick();
+    await simulateClick(SELECTORS.ZONE_CONFIRM);
+    expect(
+      (model.getters.getPivotCoreDefinition("1") as SpreadsheetPivotCoreDefinition).dataSet
+    ).toMatchObject({
+      sheetId: model.getters.getActiveSheetId(),
+      zone: toZone("A1:A100"),
+    });
+  });
 });

tests/test_helpers/pivot_helpers.ts

@@ -62,4 +62,6 @@ export const SELECTORS = {
   DUPLICATE_PIVOT: ".os-cog-wheel-menu .fa-copy",
   DELETE_PIVOT: ".os-cog-wheel-menu .fa-trash",
   FLIP_AXIS_PIVOT: ".os-cog-wheel-menu .fa-exchange",
+  ZONE_INPUT: ".o-selection-input input",
+  ZONE_CONFIRM: ".o-selection-input .o-selection-ok",
 };