Skip to content

Commit 434c060

Browse files
committed
[FIX] composer: overflow on composer at end of screen
The button to close the composer's formula assistant would overflow from the viewport and make an additional scrollbar appear when it's at the end of the screen (eg. standalone composer in the CF color scale panel). This was due to two things: 1) there was a comment with `//`, which is invalid css and disabled the `width` property of the button 2) we were using a `CLOSE_ICON_RADIUS` to compute the position of the formula assistant. But this constant wasn't actually used in the CSS, so the button could have an arbitrary width unrelated to the constant. (in practice it was 18.4px vs 18px, but this would change if we changed the font size). closes #5252 Task: 4315958 Signed-off-by: Rémi Rahir (rar) <[email protected]>
1 parent e48b96b commit 434c060

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/components/composer/composer/composer.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,10 @@ css/* scss */ `
9292
}
9393
9494
.fa-stack {
95-
// reset stack size which is doubled by default
96-
width: 1em;
97-
height: 1em;
98-
line-height: 1em;
95+
/* reset stack size which is doubled by default */
96+
width: ${CLOSE_ICON_RADIUS * 2}px;
97+
height: ${CLOSE_ICON_RADIUS * 2}px;
98+
line-height: ${CLOSE_ICON_RADIUS * 2}px;
9999
}
100100
101101
.force-open-assistant {

0 commit comments

Comments
 (0)