[IMP] Manufacturing: update MO costs #11422
Conversation
|
|
|
Hey @benderliz, This is ready for the first round of review. Thanks, |
There was a problem hiding this comment.
@hojo-odoo John, excellent work on this PR!!! I left a few relatively minor suggestions. The overall structure and writing of this doc is very easy to follow. Great job! :)
| Odoo computes |MO| costs based on the configuration of the |BoM| used to manufacture a product. This | ||
| includes the cost and quantity of components and operations listed on the |BoM|, in addition to the | ||
| operating costs of the work centers where those operations are carried out. | ||
| operating costs of the work centers where those operations are carried out, and the amount paid to | ||
| each employee who works on an operation. |
There was a problem hiding this comment.
This paragraph repeats a lot of the 'important' admonition block above.
| Odoo computes |MO| costs based on the configuration of the |BoM| used to manufacture a product. This | ||
| includes the cost and quantity of components and operations listed on the |BoM|, in addition to the |
There was a problem hiding this comment.
| Odoo computes |MO| costs based on the configuration of the |BoM| used to manufacture a product. This | |
| includes the cost and quantity of components and operations listed on the |BoM|, in addition to the | |
| Odoo computes |MO| costs based on the configuration of the |BoM| used to manufacture a product. This | |
| calculation includes the cost and quantity of components and operations listed on the |BoM|, in addition to the |
| @@ -46,40 +46,57 @@ the component's product form, and entering a value. However, any future |POs| fo | |||
| override a value entered manually, resetting the :guilabel:`Cost` field back to an automatically | |||
There was a problem hiding this comment.
Super small nitpick - it's not letting me comment on line 45, but I would personally not put a comma before "entering a value", since it's not an independent clause or an aside.
| @@ -46,40 +46,57 @@ the component's product form, and entering a value. However, any future |POs| fo | |||
| override a value entered manually, resetting the :guilabel:`Cost` field back to an automatically | |||
There was a problem hiding this comment.
| override a value entered manually, resetting the :guilabel:`Cost` field back to an automatically | |
| override a manually-entered value entered, resetting the :guilabel:`Cost` field back to an automatically |
| used than was listed on the |MO|, or if the duration of a work order is different than expected. | ||
| used than was listed on the |MO|, the duration of a work order is different than expected, or the | ||
| hourly cost of the employee performing a work order differs from the employee cost set on the work | ||
| center. |
|
|
||
| |BoM| cost | ||
| ---------- | ||
| |BoM| configuration |
There was a problem hiding this comment.
I would consider moving this section, BoM configuration, to be above component cost, work center cost, and employee cost! Since it's sort of the basis of the MO cost.
| |BoM| cost | ||
| ---------- | ||
| |BoM| configuration | ||
| ------------------- | ||
|
|
||
| Configuring a |BoM| so Odoo can accurately calculate the cost of |MOs| that use it requires two | ||
| steps. First, components **must** be added, and the required quantity specified. Second, operations |
There was a problem hiding this comment.
Maybe it could be nice for the steps to be enumerated (1) and (2), and then the steps for configuration can be listed after each of the 2 steps?
There was a problem hiding this comment.
In lines 123-124, should 'default duration` be capitalized and stylized as :guilabel:?
| per hour` section on the work center's :guilabel:`General Information` tab. For example, if `25.00` | ||
| is entered in the :guilabel:`per employee` field, it costs $25.00 per hour for *each* employee | ||
| working at the work center. | ||
| :guilabel:`General Information` tab. |
There was a problem hiding this comment.
It's not letting me edit these lines directly because there is a deleted line contained therein, but I think, instead of lines 57 - 63, it should say:
[ To set the cost of operating the work center for one hour, locate the :guilabel:Cost per hour field on the work center's :guilabel:General Information tab. The hourly cost can be set two different ways: :guilabel:per workcenter and :guilabelper employee. ]
...then continue with the examples :)
| used than was listed on the |MO|, or if the duration of a work order is different than expected. | ||
| used than was listed on the |MO|, the duration of a work order is different than expected, or the | ||
| hourly cost of the employee performing a work order differs from the employee cost set on the work | ||
| center. | ||
|
|
||
| Once the |MO| has been completed by clicking :guilabel:`Produce All`, the values in the | ||
| :guilabel:`MO Cost` column update to match those displayed in the :guilabel:`Real Cost` column. |
There was a problem hiding this comment.
It's not letting me comment on the individual lines below, but the example you walk through is awesome! Very clearly explained, and I am not left with any questions.
A couple minor suggestions/questions:
- I notice in the bullet points that single digit numbers (e.g. seven) are spelled out, while two+ digit numbers (e.g. 15) use numbers. I am familiar with this practice as a journalistic/academic writing convention, but I feel like for something like Odoo, it is kind of awkward. Personally I would prefer to see all numbers, like 1, 15, 300, etc., instead of written out. But is it an Odoo style convention we have to adhere to?
- Fairway Fields is italicized at the beginning of the example, but not when mentioned later. Is that intentional? Same with the putting green.
| .. important:: | ||
| As detailed in the :ref:`section above <manufacturing/mo-costs/work-center-cost>`, the value | ||
| entered in the :guilabel:`Hourly Cost` field on the employee's form is used to calculate the real | ||
| cost of an MO. The estimated cost of an MO, referred to as the MO cost, uses the per employee |
There was a problem hiding this comment.
| cost of an MO. The estimated cost of an MO, referred to as the MO cost, uses the per employee | |
| cost of an MO. The estimated cost of an MO, referred to as the MO cost, uses the :guilabel:`per employee` |
This PR updates the Manufacturing Order Costs doc to better explain the differences between the cost for a specific employee, and the employee cost set on a work center form.