[REF] mass_mailing, website: remove now-unused special drop in options

so_snippet_addition and so_content_addition are fully converted and can
now be removed.

The mass_mailing legacy snippet addition selector was outdated in this
commit [1].

The mass_mailing legacy content addition selector was outdated in this
commit [2]. Further updates were pushed in these commits [3] [4].

[1]: edf81c1
[2]: ee94c0c
[3]: 1dff079
[4]: 507b80a

task-3850413

Author: agau-odoo

addons/mass_mailing/static/src/js/mass_mailing_snippets.js

@@ -2,6 +2,7 @@
 
 import options from "@web_editor/js/editor/snippets.options.legacy";
 import { loadImage } from "@web_editor/js/editor/image_processing";
+import { registerSnippetAdditionSelector } from "@web_editor/js/editor/snippets.registry";
 const SelectUserValueWidget = options.userValueWidgetsRegistry['we-select'];
 import weUtils from "@web_editor/js/common/utils";
 import {
@@ -17,6 +18,8 @@ import { isCSSColor, normalizeCSSColor } from "@web/core/utils/colors";
 // Options
 //--------------------------------------------------------------------------
 
+registerSnippetAdditionSelector(".o_mail_snippet_general");
+
 // Adding compatibility for the outlook compliance of mailings.
 // Commit of such compatibility : a14f89c8663c9cafecb1cc26918055e023ecbe42
 options.registry.MassMailingBackgroundImage = options.registry.BackgroundImage.extend({

addons/mass_mailing/views/snippets_themes.xml

@@ -410,17 +410,6 @@
         data-drop-near="[data-oe-field='body_html']:not(:has(.o_layout)) > *, .oe_structure > *"
         data-drop-in="[data-oe-field='body_html']:not(:has(.o_layout)), .oe_structure"/>
 
-    <t t-set="so_snippet_addition_selector" t-translation="off">.o_mail_snippet_general</t>
-    <div id="so_snippet_addition"
-        t-att-data-selector="so_snippet_addition_selector"
-        data-drop-in=":not(p).oe_structure:not(.oe_structure_solo), :not(.o_mega_menu):not(p)[data-oe-type=html], :not(p).oe_structure.oe_structure_solo:not(:has(> section, > div))"/>
-
-    <t t-set="so_content_addition_selector" t-translation="off">.s_mail_blockquote, .s_mail_alert, .s_rating, .s_hr, .s_mail_text_highlight</t>
-    <div id="so_content_addition"
-        t-att-data-selector="so_content_addition_selector"
-        t-attf-data-drop-near="p, h1, h2, h3, ul, ol, .row > div > img, #{so_content_addition_selector}"
-        data-drop-in=".content, nav"/>
-
     <div data-js="sizing_y"
         data-selector=".o_mail_snippet_general, .o_mail_snippet_general .row > div"
         data-exclude=".o_mail_no_resize, .o_mail_no_options, .s_col_no_resize.row > div, .s_col_no_resize"/>

addons/website/static/src/snippets/s_popup/options.js

@@ -174,6 +174,8 @@ registerWebsiteOption("SnippetPopup", {
     selector: ".s_popup",
     exclude: "#website_cookies_bar",
     target: ".modal",
+    // TODO: Should this be a snippet addition selector? (see
+    //  registerSnippetAdditionSelector)
     dropIn: ":not(p).oe_structure:not(.oe_structure_solo):not([data-snippet] *), :not(.o_mega_menu):not(p)[data-oe-type=html]:not([data-snippet] *)",
 });
 

addons/website/views/snippets/snippets.xml

@@ -561,24 +561,6 @@
         data-drop-near=".row.o_grid_mode > div"
         data-exclude=".s_col_no_resize.row > div, .s_col_no_resize"/>
 
-    <t t-set="so_snippet_addition_selector" t-translation="off">section, .parallax, .s_hr</t>
-    <div id="so_snippet_addition"
-        t-att-data-selector="so_snippet_addition_selector"
-        data-drop-in=":not(p).oe_structure:not(.oe_structure_solo), :not(.o_mega_menu):not(p)[data-oe-type=html], :not(p).oe_structure.oe_structure_solo:not(:has(> section:not(.s_snippet_group), > div:not(.o_hook_drop_zone)))"/>
-        <!-- /!\ drop-in here is partly duplicated for s_popup (see dedicated options) -->
-        <!-- TODO should be improved -->
-
-    <t t-set="so_content_addition_selector" t-translation="off">
-        blockquote, .s_card:not(.s_timeline_card), .s_alert, .o_facebook_page, .s_share, .s_social_media, .s_rating,
-        .s_hr, .s_google_map, .s_map, .s_countdown, .s_chart, .s_text_highlight, .s_progress_bar, .s_badge,
-        .s_embed_code, .s_donation, .s_add_to_cart, .s_online_appointment, .o_snippet_drop_in_only, .s_image
-    </t>
-
-    <div id="so_content_addition"
-        t-att-data-selector="so_content_addition_selector"
-        t-attf-data-drop-near="p, h1, h2, h3, ul, ol, div:not(.o_grid_item_image) > img, .btn, #{so_content_addition_selector}"
-        data-drop-in="nav"/>
-
     <div data-js="SnippetSave"
         data-selector="[data-snippet], a.btn"
         t-attf-data-exclude=".o_no_save, #{so_submit_button_selector}">