[FIX] hr_holidays: accrual plans access rights

Accrual plans are not readable for regular users, so once a user has an
accrual plan set on one of his allocation, he cannot open anymore his
time off dashboard when it tries to get his allocation data (the time
off he has).

To ensure the correct computation of available time off, we add a sudo.

This has been introduced in odoo#172892

closes odoo#187888

X-original-commit: 30f7fe6
Signed-off-by: Bertrand Dossogne (bedo) <[email protected]>
Signed-off-by: Pierre Masereel (pim) <[email protected]>

Author: pimodoo

addons/hr_holidays/models/hr_leave_type.py

@@ -599,7 +599,7 @@ def _get_closest_expiring_leaves_date_and_count(self, allocations, remaining_lea
         for allocation in allocations:
             expiration_date = allocation.date_to
 
-            accrual_plan_level = allocation._get_current_accrual_plan_level_id(target_date)[0]
+            accrual_plan_level = allocation.sudo()._get_current_accrual_plan_level_id(target_date)[0]
             carryover_policy = accrual_plan_level.action_with_unused_accruals if accrual_plan_level else False
             carryover_date = False
             if carryover_policy in ['maximum', 'lost']:
@@ -626,7 +626,7 @@ def _get_closest_expiring_leaves_date_and_count(self, allocations, remaining_lea
                 if expiration_date and expiration_date == closest_expiration_date:
                     expiring_leaves_count += remaining_leaves[allocation]['virtual_remaining_leaves']
                 elif carryover_date and carryover_date == closest_expiration_date:
-                    accrual_plan_level = allocation._get_current_accrual_plan_level_id(target_date)[0]
+                    accrual_plan_level = allocation.sudo()._get_current_accrual_plan_level_id(target_date)[0]
                     expiring_leaves_count += max(0, remaining_leaves[allocation]['virtual_remaining_leaves'] - accrual_plan_level.postpone_max_days)
             if expiring_leaves_count != 0:
                 return closest_expiration_date, expiring_leaves_count