Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker image name configuration #42

Open
pgorbachev opened this issue Jun 18, 2024 · 3 comments
Open

Support docker image name configuration #42

pgorbachev opened this issue Jun 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@pgorbachev
Copy link
Collaborator

pgorbachev commented Jun 18, 2024

  1. Support configuration of docker image name for component in the following section
  docker {
      imageName = 'some image name'
  }
  1. It should be supported in
    a)
Defaults {
}

b)
component-level
c)
version range

  1. following expressions have to be also supported:
  • $namespaceFromGroupId for function that transform groupId = 'org.company.lev3.lev4' to docker namespace 'lev3/lev4'
  • $componentKey

For example, for configuration

"my-service" {
    groupId = "org.octopusden.octopus.system-test"
    docker {
        imageName = '$namespaceFromGroupId/$componentKey'
    }
}

dockerImageName will be 'octopus/system-test/my-service`

  1. dockerImageName should be added to Component model

https://github.com/octopusden/octopus-components-registry-service/blob/main/components-registry-service-core/src/main/kotlin/org/octopusden/octopus/components/registry/core/dto/Component.kt

@fishinitself
Copy link
Collaborator

@pgorbachev stupid question - if an imageName is just a function of the component ID and the component GAV , why do we need to declare it separately?

@pgorbachev pgorbachev added the enhancement New feature or request label Jun 18, 2024
@pgorbachev
Copy link
Collaborator Author

@pgorbachev stupid question - if an imageName is just a function of the component ID and the component GAV , why do we need to declare it separately?

Different rules including static name of the image have to be supported

@aryabokon
Copy link
Collaborator

Давайте сделаем версионируемым поле

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants