[BUG]: inferred web middleware type depends on import("undici-types")

[Renegade334]

What happened?

@octokit/webhooks v13.7.x (ie. versions featuring #1078) features the following emitted type pattern in dist-types/middleware/web/index.d.ts:

export declare function createWebMiddleware(webhooks: Webhooks, { path, log, }?: MiddlewareOptions): (request: Request) => Promise<import("undici-types").Response>;

The middleware return type is not specified in the source, and is inferred as Promise<import("undici-types").Response> rather than Promise<Response> for the declaration emit, via @types/node's fetch types.

Since undici-types is not a dependency of the octokit packages, this leads to the following TypeScript compilation error, depending on build environment:

error TS2307: Cannot find module 'undici-types' or its corresponding type declarations.

It looks like this has bricked a number of GitHub Actions workflows.

Versions

@octokit/webhooks v13.7.x

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

Thanks for the report, I swear that sometimes Typescript infers types out of nowhere.

Feel free to send a PR. It would be the quickest way to get it fixed

[github-actions]

🎉 This issue has been resolved in version 13.7.4 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀