Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]: Code examples, statement ending with a colon #2515

Closed
1 task done
michaelsatish opened this issue Aug 10, 2023 · 4 comments · Fixed by #2516
Closed
1 task done

[DOCS]: Code examples, statement ending with a colon #2515

michaelsatish opened this issue Aug 10, 2023 · 4 comments · Fixed by #2516
Labels
released Type: Documentation Improvements or additions to documentation

Comments

@michaelsatish
Copy link
Contributor

Describe the need

The README document has the below code statement ending with a colon. It should be a semicolon. There are three occurrence in the whole document.

import { createServer } from "node:http":

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@michaelsatish michaelsatish added Status: Triage This is being looked at and prioritized Type: Documentation Improvements or additions to documentation labels Aug 10, 2023
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Thank you for spotting those errors. Would you like to submit a fix for them?

@wolfy1339 wolfy1339 removed the Status: Triage This is being looked at and prioritized label Aug 10, 2023
@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Aug 10, 2023
@michaelsatish
Copy link
Contributor Author

@wolfy1339 You're welcome. I will submit a PR.

@wolfy1339 wolfy1339 moved this from 🔥 Backlog to 🏗 In progress in 🧰 Octokit Active Aug 10, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Aug 10, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants