Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do pre-commit hook's cppcheck need to check sim_exe/? #12

Open
mlouielu opened this issue Dec 5, 2019 · 1 comment
Open

Do pre-commit hook's cppcheck need to check sim_exe/? #12

mlouielu opened this issue Dec 5, 2019 · 1 comment

Comments

@mlouielu
Copy link
Contributor

mlouielu commented Dec 5, 2019

I found that pre-commit hook will let cppcheck run on sim_exe/ directory:

sim_exe/skyline_dm/build/mazu-sim/models/dm_fsw_interface/io_packet_format.cpp:249:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/models/dm_fsw_interface/io_packet_format.cpp:409:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/models/dm_fsw_interface/io_packet_format.cpp:484:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:86:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:202:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:281:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:350:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:408:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:486:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:595:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:687:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus.cpp:775:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_dcmbus_driver_intf.cpp:134:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dcmbus/io_list.cpp:67:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/dynamic_model/io_rocket_flight_dm.cpp:95:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_dm/build/mazu-sim/modules/ringbuffer/io_ringbuffer.cpp:81:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_gnc/build/mazu-sim/models/dm_fsw_interface/io_packet_format.cpp:75:5: error: Memory leak: temp [memleak]
    return (void*)temp;
    ^
sim_exe/skyline_gnc/build/mazu-sim/models/dm_fsw_interface/io_packet_format.cpp:150:5: error: Memory leak: temp [memleak]
...

Do we need to apply cppcheck on sim_exe/?

@dungru
Copy link
Collaborator

dungru commented Dec 20, 2019

Please take a look at the following.

9e82e20#diff-194b66c0e5a695f4c70ee3cd53f7367dR3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants