Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recorder 调用destroy后, onData还是会有输出watcher数据 #102

Open
FlyingBig opened this issue Jul 29, 2021 · 12 comments · Fixed by #106
Open

recorder 调用destroy后, onData还是会有输出watcher数据 #102

FlyingBig opened this issue Jul 29, 2021 · 12 comments · Fixed by #106

Comments

@FlyingBig
Copy link

https://codesandbox.io/s/great-jepsen-rsl1m

@cbbfcd
Copy link
Contributor

cbbfcd commented Aug 9, 2021

嗯~ input 的事件监听没有正确的 uninstall,提交了 pr。pr @FlyingBig

@FlyingBig
Copy link
Author

canvas的uninstall也存在同样的问题。 canvas的context监听错了

@cbbfcd
Copy link
Contributor

cbbfcd commented Aug 10, 2021

canvas的uninstall也存在同样的问题。 canvas的context监听错了

ok~,我康康

@cbbfcd
Copy link
Contributor

cbbfcd commented Aug 27, 2021

@FlyingBig 试试 1.2.0-alpha.22 版本~

@FlyingBig
Copy link
Author

@cbbfcd recorder被销毁后再次实例化,canvas可能会有部分属性无法监听.
image
新建canvas的context对象某些属性的PropertyDescriptor和CanvasRenderingContext2D.prototype的PropertyDescriptor 不一致.导致上图代码判断时无法重新监听.

@FlyingBig
Copy link
Author

✋还有一个问题 在fontFace.ts遇见字体体积比较大会导致String.fromCharCode.apply(null, buffer)转换失败(调用栈爆了但不了解为什么会这样 😢 )

@cbbfcd
Copy link
Contributor

cbbfcd commented Aug 27, 2021

@FlyingBig 好的,我康康,PS: 你是在你们公司的产品上用吗?深度用户啊~👍

@cbbfcd
Copy link
Contributor

cbbfcd commented Aug 27, 2021

@FlyingBig ,另外,这两种情况,可以提供一个可复现的 DEMO 吗?😂

@FlyingBig
Copy link
Author

@cbbfcd https://codesandbox.io/s/beautiful-kare-1qf74?file=/src/App.vue canvas相关问题。
至于字体问题,我没有找到在线的pdf含有中文字体文件。就木有提供demo。

@FlyingBig
Copy link
Author

@FlyingBig 好的,我康康,PS: 你是在你们公司的产品上用吗?深度用户啊~👍

对的啊。感觉挺符合我们一个项目的需求,所以在针对不同情况在做测试。 (开源真的是程序员伟大的象征啊:) )

@cbbfcd
Copy link
Contributor

cbbfcd commented Aug 30, 2021

@cbbfcd https://codesandbox.io/s/beautiful-kare-1qf74?file=/src/App.vue canvas相关问题。
至于字体问题,我没有找到在线的pdf含有中文字体文件。就木有提供demo。

@FlyingBig 👍,多提反馈啊

字体问题是 String.fromCharCodeArrayBuffer 很大的时候会爆栈,我提了一个 PR 通过切片的方式来转字符串

canvas 那个应该也修了

等合了,新版本你再试试

@cbbfcd
Copy link
Contributor

cbbfcd commented Aug 31, 2021

@FlyingBig 试试 1.2.0-alpha.24

@oct16 oct16 linked a pull request Aug 31, 2021 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants