Skip to content

Define IMGUI_VIDEO_CAPTURE_ENCODER_PATH #6

Open

Description

@jacobfriedman

It would be nice to have an IMGUI_VIDEO_CAPTURE_ENCODER_PATH definition included in imgui_capture_tool.h much like IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS[...]. In my world it would be conveniently sourced during ImGuiTestEngine_Postswap;

struct IMGUI_API ImGuiCaptureContext would contain char* VideoCaptureEncoderPath = IMGUI_VIDEO_CAPTURE_ENCODER_PATH or along those lines so we don't have to input it via the UI.

Thoughts?

Activity

  1. jacobfriedman commented on Jan 16, 2023

    @jacobfriedman
    ContributorAuthor

    As a sidenote, IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS_FOR_FFMPEG should probably have the suffix dropped.

  2. ocornut commented on Feb 23, 2023

    @ocornut
    Owner

    Hello,

    struct IMGUI_API ImGuiCaptureContext would contain char* VideoCaptureEncoderPath = IMGUI_VIDEO_CAPTURE_ENCODER_PATH or along those lines so we don't have to input it via the UI.

    If you want to change the default value or force the value, you can write to test_io.VideoCaptureEncoderPath[] ?
    If you ship or use a software that has an ffmpeg executable you can should setup that path yourself in the code.
    We don't ship ffmpeg.exe in neither Test Suite or Test Engine so it wouldn't make sense to set a default.

    As a sidenote, IMGUI_CAPTURE_DEFAULT_VIDEO_PARAMS_FOR_FFMPEG should probably have the suffix dropped.

    I don't understand either. They are specifically default params in the case of using FFMPEG as an encoder.
    We don't assume the encoder is FFMPEG but provide default params for that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions