Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation should specify the required jsdom version #69

Open
erdeszt opened this issue Jun 30, 2017 · 0 comments
Open

The documentation should specify the required jsdom version #69

erdeszt opened this issue Jun 30, 2017 · 0 comments

Comments

@erdeszt
Copy link

erdeszt commented Jun 30, 2017

I did as a documentation said and installed the latest jsdom npm package(v11.0.0) but I've got an error when running the tests: TypeError: jsdom.createVirtualConsole is not a function. I had to downgrade to v9.0.0 to make the tests run.

The documentation should specify the version of jsdom that the app relies on(and it probably should be updated I guess). If you are ok with adding @9.0.0 to the documentation I can do a quick PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant