This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
Add a quotes page #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpengboy
approved these changes
Jan 21, 2019
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <title>ocf ircbot quotes</title> |
kkuehlz
approved these changes
Jan 21, 2019
dkess
approved these changes
Jan 21, 2019
|
I don't think it's a good idea for this to be open to the public, especially since many of us use our real names as our nicks. admittedly a lot of this can be found on moffle or something, but I'm still hesitant. |
|
We could hold off on merging this until we have a proper webserver setup, then we could put this behind a password wall. |
|
We do have a proper webserver setup now, so a password wall could be implemented in PAM. |
|
I'll close this, if it does actually end up happening it'll need password auth of some kind and to be reformatted to fit with the current flask web server. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what the page looks like (well the top part anyway). I'd prefer to put a screenshot here than a live page link to my dev version when it might not be running and the link will very quickly get stale anyway:
rt#6832 is what inspired this, well that and me wanting a quotes page instead of trying to remember part of a quote and having to search for it...
I'd like to split out the web server from the help plugin and put it in its own plugin (and add hooks for other plugins to use it hopefully), but I think that can come in a future PR, it's not really related to this change at all.
Closes #147.