From 30e80333692170046e12f8221049f155f1ed8e90 Mon Sep 17 00:00:00 2001
From: yuyi <yuyi.wsy@oceanbase.com>
Date: Thu, 29 Aug 2024 17:44:10 +0800
Subject: [PATCH] fix(coordinator): added logging message for finished tasks

---
 pkg/coordinator/coordinator.go | 36 +++++++++++++++++++++++-----------
 1 file changed, 25 insertions(+), 11 deletions(-)

diff --git a/pkg/coordinator/coordinator.go b/pkg/coordinator/coordinator.go
index 235cab751..8ffda10b8 100644
--- a/pkg/coordinator/coordinator.go
+++ b/pkg/coordinator/coordinator.go
@@ -130,19 +130,33 @@ func (c *Coordinator) executeTaskFlow(f *tasktypes.TaskFlow) {
 	case taskstatus.Running:
 		// check task status and update cr status
 		taskResult, err := task.GetTaskManager().GetTaskResult(f.OperationContext.TaskId)
-
-		if err != nil {
-			c.Logger.Error(err, "Get task result got error", "task id", f.OperationContext.TaskId)
-			c.Manager.PrintErrEvent(err)
-			f.OperationContext.TaskStatus = taskstatus.Failed
-		} else if taskResult != nil {
-			c.Logger.V(1).Info("Task finished", "task id", f.OperationContext.TaskId, "task result", taskResult)
-			f.OperationContext.TaskStatus = taskResult.Status
-			if taskResult.Error != nil {
-				c.Manager.PrintErrEvent(taskResult.Error)
+		if err != nil || taskResult != nil {
+			resMeta := c.Manager.GetMeta()
+			ns := resMeta.GetNamespace()
+			resVersion := resMeta.GetResourceVersion()
+			resName := resMeta.GetName()
+			loggingPairs := []interface{}{
+				"flowName", f.OperationContext.Name,
+				"taskId", f.OperationContext.TaskId,
+				"taskName", f.OperationContext.Task,
+				"namespace", ns,
+				"resourceVersion", resVersion,
+				"resourceName", resName,
+			}
+			if err != nil {
+				c.Logger.Error(err, "Get task result got error", loggingPairs...)
+				c.Manager.PrintErrEvent(err)
+				f.OperationContext.TaskStatus = taskstatus.Failed
+			} else if taskResult != nil {
+				f.OperationContext.TaskStatus = taskResult.Status
+				if taskResult.Error != nil {
+					c.Logger.Error(taskResult.Error, "Task failed", loggingPairs...)
+					c.Manager.PrintErrEvent(taskResult.Error)
+				} else {
+					c.Logger.V(1).Info("Task finished successfully", loggingPairs...)
+				}
 			}
 		}
-		// Didn't get task result, task is still running
 	case taskstatus.Successful:
 		// clean operation context and set status to target status
 		if !f.HasNext() {