Allow using msys2 instead of cygwin #857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
force-pushed
the
master
branch
3 times, most recently
from
83f24cd to
96de1ac
Compare
tobil4sk
force-pushed
the
feature/msys2
branch
from
e7a744c to
1dd04e9
Compare
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- .github/workflows/workflow.yml: Evaluated as low risk
- action.yml: Evaluated as low risk
Comments suppressed due to low confidence (2)
packages/setup-ocaml/src/constants.ts:101
- The error message 'unrecognized value for windows-environment' could be more descriptive. Consider specifying the acceptable values, e.g., 'Unrecognized value for windows-environment. Accepted values are "cygwin" or "msys2".'
core.error("unrecognized value for windows-environment");
packages/setup-ocaml/src/constants.ts:89
- Ensure that the new behavior introduced by the 'WINDOWS_ENVIRONMENT' constant is covered by tests.
export const WINDOWS_ENVIRONMENT: "cygwin" | "msys2" = (() => {
| } catch { | ||
| // finally check the default msys directory | ||
| const defaultRoot = "C:\\msys64"; | ||
| testMsys2Installation(defaultRoot); |
There was a problem hiding this comment.
The function testMsys2Installation should be awaited to handle the promise correctly. Change it to await testMsys2Installation(defaultRoot);.
Suggested change
| testMsys2Installation(defaultRoot); | |
| await testMsys2Installation(defaultRoot); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides support for using msys2 instead of cygwin as the environment for windows. It can be enabled with:
Otherwise, it still defaults to cygwin.
It will use the msys2 installation specified as follows:
MSYS2_ROOTenvironment variablePATH, it will use the installation that the pacman binary belongs to.C:\msys64(available in the windows image for github actions: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#msys2).It does not cache the msys2 install, but it should be possible for setup-msys2 to handle that: https://github.com/msys2/setup-msys2.
This closes #846.