Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: regular failure of 4 tests #11450

Closed
maiste opened this issue Feb 6, 2025 · 0 comments · Fixed by #11454
Closed

ci: regular failure of 4 tests #11450

maiste opened this issue Feb 6, 2025 · 0 comments · Fixed by #11454
Labels
bug chore Something that just needs to be done.

Comments

@maiste
Copy link
Collaborator

maiste commented Feb 6, 2025

Since the introduction of #11302, some tests seem to fail with the following errors:

Unbound module Mutex

This PR indeed introduces a call to a Mutex module in vendor/opam-file-format.

This issue concerns the following tests:

  • Coq 8.16.1
  • Wasm_of_ocaml
  • Build monorepo benchmark docker image
  • Build (ocaml-base-compiler.4.14.2,system-msvc, windows-latest

The common thing is that they all worked on 4.14.X. However, I have check in the manual, the module Mutex is available.

Does it require to be added to the deps as Unix for this version? Any ideas about this @Leonidas-from-XIV, @gridbugs and @rgrinberg?
@maiste maiste added bug chore Something that just needs to be done. labels Feb 6, 2025
@maiste maiste mentioned this issue Feb 6, 2025
Closed
Leonidas-from-XIV added a commit to Leonidas-from-XIV/dune that referenced this issue Feb 7, 2025
@Leonidas-from-XIV
Remove Mutex
13ed7ee 
As discussed in ocaml#11451 this removes the mutex that was added in ocaml#11302.

Fixes ocaml#11450
Fixes ocaml#11451

Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug chore Something that just needs to be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Mutex Leonidas-from-XIV/dune
fix: add missing thread flag to support Mutex maiste/dune
1 participant
@maiste