Rename num_additional_domains to num_domains for setup_pool
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sudha247
approved these changes
Jul 25, 2022
|
|
||
| Raises {!Invalid_argument} when [num_additional_domains] is less than 0. *) | ||
| Raises {!Invalid_argument} when [num_domains] is less than 0. *) | ||
|
|
||
| val teardown_pool : pool -> unit | ||
| (** Tears down the task execution pool. *) |
There was a problem hiding this comment.
Unable to comment below - do you think it's worth mentioning in the run function that the calling domain also participates in executing the task, thereby running it on n+1 domains where n is the number of domains in the pool?
There was a problem hiding this comment.
Yes, and I'm happy to update this PR after understanding the semantics better. I suppose it would happen only when await or parallel_* is called. (That is, the calling domain could be blocked.) Is that correct?
There was a problem hiding this comment.
@Sudha247 I believe I have updated the documentation. Please check. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #77. This will probably break all current code, but I think it is worth it (especially before 5.0 is officially out).