Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frozen set issue #25

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Fix frozen set issue #25

merged 3 commits into from
Dec 29, 2022

Conversation

obulat
Copy link
Owner

@obulat obulat commented Dec 29, 2022

Fixes #24

This PR fixes the linked issue by making sure that the calculate_phonetic_attributes always returns the same type.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #25 (02b3833) into main (bcddaff) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   86.75%   86.76%           
=======================================
  Files          10       10           
  Lines        2938     2939    +1     
=======================================
+ Hits         2549     2550    +1     
  Misses        389      389           
Impacted Files Coverage Δ
zeyrek/rulebasedanalyzer.py 86.99% <ø> (ø)
zeyrek/attributes.py 97.19% <85.71%> (+0.01%) ⬆️
zeyrek/morphotactics.py 96.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@obulat obulat merged commit 5adc7c7 into main Dec 29, 2022
@obulat obulat deleted the fix/frozen_set_issue branch December 29, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'frozenset' object has no attribute 'add'
1 participant