Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when loading scene collection with empty name #11609

Open
Penwy opened this issue Dec 9, 2024 · 4 comments
Open

Crash when loading scene collection with empty name #11609

Penwy opened this issue Dec 9, 2024 · 4 comments

Comments

@Penwy
Copy link
Contributor

Penwy commented Dec 9, 2024

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

31.0.0

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/EUJlQEEsRnaoEhWQ

OBS Studio Crash Log URL

https://obsproject.com/logs/kJefYxixNe5p0LSB

Expected Behavior

Crashes shouldn't happen even when loading incorrect configurations.

Current Behavior

When loading a scene collection file with an empty "name" field, or no such field at all, obs crashes.

Steps to Reproduce

  1. Download this Scene Collection file.
  2. Put it directly in the obs scene collections folder.
  3. Start obs.
  4. Notice crash.

...

Anything else we should know?

I have no idea what could cause a scene collection to have an empty name, but it happened in support, and imo, should be handled instead of crashing.

@RytoEX
Copy link
Member

RytoEX commented Dec 10, 2024

What happens in 30.2.3?

@Penwy
Copy link
Contributor Author

Penwy commented Dec 10, 2024

in pre-31, the scene collection loads correctly and is given the same name as its filename.

@RytoEX
Copy link
Member

RytoEX commented Dec 11, 2024

in pre-31, the scene collection loads correctly and is given the same name as its filename.

Does 30.2.3 then correct the JSON by saving a value for the "name" key?

@Penwy
Copy link
Contributor Author

Penwy commented Dec 12, 2024

I should have checked further, my apologies.
It does load the scene collection and show it in the menu, with the same name as its filename, but upon trying to switch to it, it changes its name to that of the current scene collection (pre-switch), and wipes the current scene collection.
The file is then saved with the name of the pre-switch scene collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants