Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS CI failing when creating a release without notarization #131

Open
ashmanix opened this issue Nov 21, 2024 · 1 comment
Open

MacOS CI failing when creating a release without notarization #131

ashmanix opened this issue Nov 21, 2024 · 1 comment

Comments

@ashmanix
Copy link

Operating System Info

macOS 14

Other OS

No response

OBS Studio Version

30.2.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://github.com/ashmanix/obs-plugin-countdown/actions/runs/11943431054/job/33309910089

OBS Studio Crash Log URL

No response

Expected Behavior

When creating a release the Github actions should complete without error.

Current Behavior

Under the Build for macOS action step I get an error on the Package Plugin step of the process. The error is as follows:

Error: The template is not valid. ashmanix/obs-plugin-countdown/.github/workflows/build-project.yaml@8756d948a831e70f579bc3b40252990d905168d5 (Line: 151, Col: 21): Error reading JToken from JsonReader. Path '', line 0, position 0.

This indicates an issue with line 152 of the build-project.yaml file where the variable notarize is being decided upon two variables from previous steps but when trying to parse these using fromJSON the error occurs. Just a note that all previous variables seem to parse fine.

Steps to Reproduce

  1. Create a tag for the plugin repo code
  2. Allow build and package Github action to automatically run

Anything else we should know?

My plugin code is available here: https://github.com/ashmanix/obs-plugin-countdown

I had this issue with another plugin before and ended up modifying the line to the following to get it to run:
notarize: ${{ fromJSON(needs.check-event.outputs.notarize) && fromJSON(steps.codesign.outputs.haveNotarizationUser) }}
That was for the code located here: https://github.com/ashmanix/blur-filter-obs-plugin/blob/main/.github/workflows/build-project.yaml#L140 . Note that in both cases notarisation is set to false.

@RytoEX
Copy link
Member

RytoEX commented Nov 21, 2024

This is a known issue and is addressed by #126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants