perf: Simplify getSettings()

[claremacrae]

Description

getSettings() is called often in the plugin.

It currently does a lot of work for every call:

export const getSettings = (): Settings => {
    // Check to see if there are any new options that need to be added to the user's settings.
    addNewOptionsToUserSettings(Feature.settingsFlags, settings.features);
    addNewOptionsToUserSettings(defaultSettings.loggingOptions.minLevels, settings.loggingOptions.minLevels);
    addNewOptionsToUserSettings(defaultSettings.debugSettings, settings.debugSettings);

    // In case saves pre-dated StatusConfiguration.type
    // TODO Special case for symbol 'X' or 'x' (just in case)
    settings.statusSettings.customStatuses.forEach((s, index, array) => {
        const newType = Status.getTypeFromStatusTypeString(s.type);
        array[index] = new StatusConfiguration(
            s.symbol ?? ' ',
            s.name,
            s.nextStatusSymbol ?? 'x',
            s.availableAsCommand,
            newType,
        );
    });

    return { ...settings };
};

Required Steps

It would be sensible to move everything but the last line out to some function like updateAndReSaveSettings() that is called in main.ts - so that this updating is only done oncer per session, instead of once per call to getSettings().

How to Test

No response