Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't find git root when inside a submodule #152

Open
adamwight opened this issue Feb 22, 2021 · 0 comments
Open

Doesn't find git root when inside a submodule #152

adamwight opened this issue Feb 22, 2021 · 0 comments

Comments

@adamwight
Copy link

No hooks are installed when the repo has been cloned as a submodule. In this case, the .git file is plain text pointing to a directory under the parent .git/modules/....

I see code to handle this case, but it is unreachable because the condition here triggers first: https://github.com/observing/pre-commit/blob/master/install.js#L26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamwight