Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incoming tokens are not validated #1

Open
paulgregg opened this issue Oct 9, 2015 · 3 comments
Open

incoming tokens are not validated #1

paulgregg opened this issue Oct 9, 2015 · 3 comments

Comments

@paulgregg
Copy link

The incoming token isn't checked - so anyone could post.

@obra
Copy link
Owner

obra commented Oct 9, 2015

On Fri, Oct 09, 2015 at 01:44:11PM -0700, paulgregg wrote:

The incoming token isn't checked - so anyone could post.

With a public hook url, yep. My plan had been to require sites to
include their incoming hook url as a param and to check that as a
poor-man's passphrase. Patches welcome.

@paulgregg
Copy link
Author

I've forked it because you've saved me a ton of work figuring this out :)

My use case is a small number of teams with multiple 1-1 channels between the teams - so it needs to support multiple tokens, multiple targets/peers (but not the any peer but me). I've changed the config significantly to handle this - but will tweak more first before sharing the code back. You are welcome to any changes. Token checking per incoming peer/channel is done.

@paulgregg
Copy link
Author

PR in flight... you might not like it tho since it changes the default behaviour of 1-many peers in favour of requiring explicitly targetting incoming channels at specific peers and channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants