Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated.event now requires a second argument for options at LightboxOverlay #153

Open
CarmineRumma opened this issue Feb 25, 2022 · 2 comments

Comments

@CarmineRumma
Copy link

Hi! 👋

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-lightbox/LightboxOverlay.js b/node_modules/react-native-lightbox/LightboxOverlay.js
index 9e01f9a..a84fd9d 100644
--- a/node_modules/react-native-lightbox/LightboxOverlay.js
+++ b/node_modules/react-native-lightbox/LightboxOverlay.js
@@ -99,7 +99,8 @@ export default class LightboxOverlay extends Component {
       onPanResponderMove: Animated.event([
         null,
         { dy: this.state.pan }
-      ]),
+      ],
+        { useNativeDriver: false }),
       onPanResponderTerminationRequest: (evt, gestureState) => true,
       onPanResponderRelease: (evt, gestureState) => {
         if(Math.abs(gestureState.dy) > DRAG_DISMISS_THRESHOLD) {
@rumfiske
Copy link

rumfiske commented Sep 2, 2023

Same error here. Hope it wil lget fixed soon

@dmackinn
Copy link

dmackinn commented Nov 3, 2023

This package hasn't been updated since Dec 15, 2019 so it's doubtful the maintainer will do anything. I created a patch using the same fix as Carmine and was going to submit a PR but I noticed that this Github issue already existed. If you use the patch-package package you can retain the change between npm installs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants