Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the listing XML element contains binary code #845

Closed
yegor256 opened this issue Nov 8, 2024 · 5 comments
Closed

the listing XML element contains binary code #845

yegor256 opened this issue Nov 8, 2024 · 5 comments
Assignees
@volodya-lombrozo
Labels
enhancement New feature or request

Comments

@yegor256
Copy link
Member

yegor256 commented Nov 8, 2024

Currently, if I understand correctly, the <listing/> element in the XMIR generated by JEO, contains Base64-encoded content of the .class file that was disassembled. This doesn't help much in comprehending the XMIR content. Would be much better if we can put there Java code disassembled by some Bytecode-to-Java disassembler, maybe this one: https://github.com/Storyyeller/Krakatau

Or maybe just javap?
@yegor256
Copy link
Member Author

yegor256 commented Nov 8, 2024

@volodya-lombrozo please, check

@volodya-lombrozo volodya-lombrozo self-assigned this Nov 8, 2024
@volodya-lombrozo volodya-lombrozo added the enhancement New feature or request label Nov 8, 2024
@volodya-lombrozo
Copy link
Member

@yegor256 Of course, it's a good thing. I guess, we can add both options: 1) javap and 2) decompiler

@yegor256
Copy link
Member Author

yegor256 commented Nov 8, 2024

@volodya-lombrozo javap looks like the easiest solution at the moment, would be great to have it ASAP. Without it, it's very hard or almost impossible to deal with the XMIR -- I simply can't understand what does it represent.

volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 13, 2024
@volodya-lombrozo
feat(objectionary#845): add one more class that knows how to pretty-p…
13693b7 
…rint bytecode
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 13, 2024
@volodya-lombrozo
feat(objectionary#845): verify new implementation on all simple integ…
dd103db 
…ration tests
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 13, 2024
@volodya-lombrozo
feat(objectionary#845): add one more puzzle to continue with code lis…
571bc31 
…ting later
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 13, 2024
@volodya-lombrozo
feat(objectionary#845): remove the old listing representation
6d7a5dd
@volodya-lombrozo volodya-lombrozo mentioned this issue Nov 13, 2024
Merged
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 13, 2024
@volodya-lombrozo
feat(objectionary#845): fix all the code offences
3636715
@0pdd 0pdd mentioned this issue Nov 13, 2024
Open
@0pdd
Copy link

0pdd commented Nov 13, 2024

@yegor256 the puzzle #865 is still not solved.

@volodya-lombrozo
Copy link
Member

@yegor256 This issue was solved in the recent release. Can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @0pdd @volodya-lombrozo