Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build enhancement - convert from flow to typescript #1452

Open
sjd78 opened this issue Jun 17, 2021 · 0 comments
Open

Build enhancement - convert from flow to typescript #1452

sjd78 opened this issue Jun 17, 2021 · 0 comments

Comments

@sjd78
Copy link
Member

sjd78 commented Jun 17, 2021

Convert from flow to typescript.

Flow is no longer integrated with the dev server or production build. It is 100% manual now. Either yarn flow or an your favorite ide with a flow integration will report type error. Type errors are ignored in the build.

This will give us better typing support in builds and tooling. Also, gives us the option to drop react PropTypes in favor of normal typescript typing. Patternfly-react has been doing this for awhile now.

There are a number of ways to automatically convert flow to typescript. For an example and some additional rationale: https://skovhus.github.io/blog/flow-to-typescript-migration/

Originally posted by @sjd78 in #1359 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant