Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add example of applying policy by guest's hostname #27

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

inflatador
Copy link
Contributor

@inflatador inflatador commented Sep 7, 2024

Show how to set a variable based on guest
properties, and how to conditionally apply
policy based on the guest property.

Addresses this issue

@inflatador inflatador requested a review from nyoxi as a code owner September 7, 2024 13:54
@nyoxi
Copy link
Member

nyoxi commented Oct 3, 2024

Thanks for the patch. Unfortunately your commit is missing Signed-of-by line. Once that is added your patch can be merged.

@inflatador
Copy link
Contributor Author

@nyoxi Thanks for your patience! I added the requested Signed-off-by line, let me know you need anything else.

@nyoxi
Copy link
Member

nyoxi commented Oct 18, 2024

@inflatador hello, unfortunately CI is complaining. First issue is that the DCO check is still failing. Author of the commit is set to Private User but the SoB line contains your name.

Second issue is with our GitHub actions. I have opened #28 to address this but I run into another issue.

@nyoxi
Copy link
Member

nyoxi commented Oct 21, 2024

CI is fixed. Please don't forget to rebase once you fix your issue with DCO.

nyoxi and others added 2 commits October 25, 2024 17:18
EL8 is now EOL

Signed-off-by: Tomáš Golembiovský <[email protected]>
guest's hostname

Show how to set a variable based on guest
properties, and how to conditionally apply
policy based on the guest property.

Signed-off-by: Brian King <[email protected]>
@nyoxi nyoxi merged commit 83f244a into oVirt:master Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants