Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating iteration configs for data types #85

Open
3 tasks
o355 opened this issue May 30, 2018 · 6 comments
Open
3 tasks

Separating iteration configs for data types #85

o355 opened this issue May 30, 2018 · 6 comments

Comments

@o355
Copy link
Owner

o355 commented May 30, 2018

Confusing title, but the TL;DR is that there's 1 config value for setting iterations for a lot of data types. We need to separate them all out.

To do list:

  • Change main script config loading to read new config options
  • Change iteration code to read new config options
  • Propagate config changes into the setup file, configsetup file, and configupdate file.
@o355
Copy link
Owner Author

o355 commented Jun 1, 2018

Now working on this issue, ETA is next week.

At this point, we have a few different loop config variables, all in the UI section.

  • detailedinfoloops controls 1.5-day hourly & 10-day hourly, historical & yesterday hourly, hurricane detailed info, and tide info.
  • forecast_detailedinfoloops controls the 10-day hourly forecast.
  • alerts_usiterations controls US alert info.
  • alerts_euiterations controls EU alert info.

The new hope is for every data type to have their own unique variable.

  • hourlyinfo_iterations - Controls 1.5 day/10 day hourly, 2 by default
  • forecastinfo_iterations - Controls 10 day forecast, 3 by default
  • hurricaneinfo_iterations - Controls hurricane detailed info, 2 by default. This default number will likely change during QA.
  • tideinfo_iterations - Controls tide detailed info, 6 by default.
  • historicalhourly_iterations - Controls historical hourly info, 2 by default.
  • yesterdayhourly_iterations - Controls yesterday hourly info, 3 by default.
  • alertsus_iterations - Controls US alert info, 1 by default.
  • alertseu_iterations - Controls EU alert info, 2 by default.

Now modifying the todo list, ETA for fix is 6/8.

@o355
Copy link
Owner Author

o355 commented Jun 1, 2018

Now working on PyWeather to read the new variables.

If you have an indev copy of PyWeather and git pull it'll be broken for a few days.

@o355
Copy link
Owner Author

o355 commented Jun 1, 2018

Also while we're working with the config loading part of code let's make sure that occurred. is moved to the 1st line of print and not the 2nd.

Oh and let's also completely redo the entire logger section for config variables

@o355
Copy link
Owner Author

o355 commented Jun 1, 2018

Finished up with coding for reading the variables.

Now on to other various stuff.

@o355
Copy link
Owner Author

o355 commented Jun 1, 2018

I make sure that print statements looked good.

Refactoring all the config logger statements then back to the ACTUAL plan.

@o355
Copy link
Owner Author

o355 commented Jun 1, 2018

New ETA for completion is this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant