Save != publish

[nuest]

When creating a new ERC, the "Save" button is actually a publish button. It would be helpful, especially for public links for review (#118) and to avoid authors making their ERCs public unintentionally, if "Save" only updates the metadata, and an extra "Publish" button _with a "are you sure" warning for making the ERC publicly available.

I think we had it that way in the old UI, right?

The "are you sure"-dialog could also point out that you can get in touch with the o2r team to get a publicly shareable link.

[MarkusKonk]

No, we never had that. We only distinguished between candidates and and non-candicates (which get the status automatically after updating the metadata). Distinction between unpublished ERCs (non-candidates) and published ERCs (also non-candidates) has not been considered somewhere so far, not even in the metadata. But we could just add a field from the UI-side.

[nuest]

For me, a candidate is an unpublished compendium, so sorry for not being clear.

There are no "unpublished ERCs", just "candidates", "candidates with a public link", and "published ERCs".

[MarkusKonk]

The point is that candidate at the moment is either true or false, no "true with public link" so far. I will just change the metadata.

[MarkusKonk]

But: As I rememver, one of your services changes the candidate state automatically from true to false after updating the metadata, if I remember that correctly.

[nuest]

You are correct! https://o2r.info/api/compendium/candidate/

I suggest:

• I update the API to enable metadata updates without publishing
  • The client will have to set candidate: false
• The "Save" button is still renamed to "Publish", because that is what it does, and we add again the "Are you sure" question; the window for this question can also tell the author, that to delete a compendium, she has to reach out to the o2r team (and give our email)
• When the API is updated, we can add an extra "Save metadata" button

[MarkusKonk]

Agreed

[nuest]

@MarkusKonk Can you go ahead with the button renaming and adding of the "are you sure" question?

[MarkusKonk]

Is the API update done?

[nuest]

No, but at the moment "Save" effectively is "Publish" and can be renamed. Then, when the API exists (I don't want to rush that right now) we can add the additional "Save" button.

[nuest]

1. API spec > Add option to save without publish, add action for publishing api#85
2. API implementation > https://github.com/o2r-project/o2r-muncher/issues
3. UI implementation (this issue)