Skip to content

Commit d834084

Browse files
committed
CI/tests: use env vars instead of plain text
1 parent 0be9e4a commit d834084

File tree

1 file changed

+18
-21
lines changed

1 file changed

+18
-21
lines changed

.github/workflows/tests.yaml

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ env:
1717
MINA_PANIC_ON_BUG: true
1818
CARGO_INCREMENTAL: 1
1919
RUSTFLAGS: "-C overflow-checks=off -C debug-assertions=off"
20+
RUST_STABLE_VERSION: "1.84"
21+
RUST_NIGHTLY_VERSION: "nightly"
22+
OCAML_VERSION: "4.14.2"
2023

2124
concurrency:
2225
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -31,17 +34,14 @@ jobs:
3134
- name: Setup Rust
3235
uses: ./.github/actions/setup-rust
3336
with:
34-
toolchain: 1.84
37+
toolchain: ${{ env.RUST_STABLE_VERSION }}
3538
enable-cache: false
3639
- name: Clean cargo cache
3740
run: cargo clean
3841

3942
ledger-tests:
4043
timeout-minutes: 20
4144
runs-on: ubuntu-24.04
42-
strategy:
43-
matrix:
44-
ocaml_version: [4.14.2]
4545
steps:
4646
- name: Git checkout
4747
uses: actions/checkout@v5
@@ -52,12 +52,12 @@ jobs:
5252
- name: Use shared OCaml setting up steps
5353
uses: ./.github/actions/setup-ocaml
5454
with:
55-
ocaml_version: ${{ matrix.ocaml_version }}
55+
ocaml_version: ${{ env.OCAML_VERSION }}
5656

5757
- name: Setup Rust
5858
uses: ./.github/actions/setup-rust
5959
with:
60-
toolchain: nightly
60+
toolchain: ${{ env.RUST_NIGHTLY_VERSION }}
6161
cache-prefix: ledger-v0
6262

6363
- name: Download circuits files
@@ -82,7 +82,7 @@ jobs:
8282
- name: Setup Rust
8383
uses: ./.github/actions/setup-rust
8484
with:
85-
toolchain: nightly
85+
toolchain: ${{ env.RUST_NIGHTLY_VERSION }}
8686
cache-prefix: p2p-messages-v0
8787

8888
- name: Download circuits files
@@ -127,9 +127,6 @@ jobs:
127127
vrf-tests:
128128
timeout-minutes: 20
129129
runs-on: ubuntu-24.04
130-
strategy:
131-
matrix:
132-
ocaml_version: [4.14.2]
133130
steps:
134131
- name: Git checkout
135132
uses: actions/checkout@v5
@@ -140,12 +137,12 @@ jobs:
140137
- name: Use shared OCaml setting up steps
141138
uses: ./.github/actions/setup-ocaml
142139
with:
143-
ocaml_version: ${{ matrix.ocaml_version }}
140+
ocaml_version: ${{ env.OCAML_VERSION }}
144141

145142
- name: Setup Rust
146143
uses: ./.github/actions/setup-rust
147144
with:
148-
toolchain: nightly
145+
toolchain: ${{ env.RUST_NIGHTLY_VERSION }}
149146
cache-prefix: vrf-v0
150147

151148
- name: Build vrf tests
@@ -167,7 +164,7 @@ jobs:
167164
- name: Setup Rust
168165
uses: ./.github/actions/setup-rust
169166
with:
170-
toolchain: 1.84
167+
toolchain: ${{ env.RUST_STABLE_VERSION }}
171168
cache-prefix: p2p-v0
172169

173170
- name: Test p2p crate
@@ -187,12 +184,12 @@ jobs:
187184
- name: Use shared OCaml setting up steps
188185
uses: ./.github/actions/setup-ocaml
189186
with:
190-
ocaml_version: 4.14.2
187+
ocaml_version: ${{ env.OCAML_VERSION }}
191188

192189
- name: Setup Rust
193190
uses: ./.github/actions/setup-rust
194191
with:
195-
toolchain: 1.84
192+
toolchain: ${{ env.RUST_STABLE_VERSION }}
196193
cache-prefix: build-v0
197194

198195
- name: Release build
@@ -235,7 +232,7 @@ jobs:
235232
- name: Setup Rust
236233
uses: ./.github/actions/setup-rust
237234
with:
238-
toolchain: 1.84
235+
toolchain: ${{ env.RUST_STABLE_VERSION }}
239236
cache-prefix: build-v0
240237

241238
- name: Run account tests
@@ -254,12 +251,12 @@ jobs:
254251
- name: Use shared OCaml setting up steps
255252
uses: ./.github/actions/setup-ocaml
256253
with:
257-
ocaml_version: 4.14.2
254+
ocaml_version: ${{ env.OCAML_VERSION }}
258255

259256
- name: Setup Rust
260257
uses: ./.github/actions/setup-rust
261258
with:
262-
toolchain: 1.84
259+
toolchain: ${{ env.RUST_STABLE_VERSION }}
263260
cache-prefix: build-tests-v0
264261

265262
- name: Build tests
@@ -285,12 +282,12 @@ jobs:
285282
- name: Use shared OCaml setting up steps
286283
uses: ./.github/actions/setup-ocaml
287284
with:
288-
ocaml_version: 4.14.2
285+
ocaml_version: ${{ env.OCAML_VERSION }}
289286

290287
- name: Setup Rust
291288
uses: ./.github/actions/setup-rust
292289
with:
293-
toolchain: 1.84
290+
toolchain: ${{ env.RUST_STABLE_VERSION }}
294291
cache-prefix: build-tests-webrtc-v0
295292

296293
- name: Build tests
@@ -316,7 +313,7 @@ jobs:
316313
- name: Setup Rust
317314
uses: ./.github/actions/setup-rust
318315
with:
319-
toolchain: nightly
316+
toolchain: ${{ env.RUST_NIGHTLY_VERSION }}
320317
cache-prefix: build-wasm-v0
321318

322319
- name: Setup wasm tooling

0 commit comments

Comments
 (0)